Write current state to a statefile (preparation for the future systray applet) #148
Conversation
|
I've opted to not include a remove line for icons just yet as it might confuse automatic merging. |
|
Are we able to use the already existing statedir mechanism implemented in users' $XDG_STATE_HOME dir instead of using That will only dropping the change in the Makefile and the addition of the "res/state" file as well as avoiding having another file write-able by world (666 mode). |
|
Good point. I have no idea how I missed that. |
If you are referring to dropping "superfluous" icon (like "checking" and "installing"), I'll include that in the incoming "dropping icon changes" PR ;) |
Hey hey, no problem don't worry 😄 |
No, sorry. We still have an icon directory variable knocking around. Since it's a line edited by one of the other PRs I'll hold of on editing it in here too |
Yeah okay, fair enough. I'll drop it myself in another PR a bit later today and I'll rebase other PRs if needed. |
- update comments
|
Ready to be merged. Here again I'm waiting for my incoming PR about dropping the icon changing to sync the merge of the different PR (to avoid having breaking changes in the main branch for too long). Thanks once again for your awesome work! |
|
Anytime! I look forward to your critique of the next PR! 😀 |
I'm currently making a first read of it to acknowledge the content and I'll eventually leave a few comments if I have some, but I'll probably make an actual review later this evening as I'll be AFK for a few hours right now 😛 I'll also add you as a reviewer of the "dropping changing icon" PR since it's all part of the same effort, if that's okay for you! |
Sounds good to me!
No worries! I'll be AFK myself for large swathes for the next few days, should be able to reply on github but will be slower on commits. |
Antiz96
changed the title
When changing state write it to a statefile.
By default install to and use
/var/lib/arch-update/state, but allow User or System to specify with env variableARCH_UPDATE_STATEset to a file path.This is in preparation of a system tray icon, and is the method of telling the icon to change.
Later on we could expand it to have more information than a simple icon-name, but it will suffice as a first step.
Addresses parts of #146